User "MarkAHershberger" posted a comment on MediaWiki.r87326.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87326#c16510
Commit summary:

Fix Bug 28354: Edit tab is shown as "view source" for blocked users, which 
breaks squid caching

* Skip user block checks for Title::quickUserCan(). This restores the behavior 
from 1.16 rsp. before r65504.
* Remove unnecessary check for "$short && count($errors)", this is already 
handled by getUserPermissionsErrorsInternal().

Comment:

Thanks for finding this and fixing it.  Do you think you could add/update the 
tests from my revision that seems to have caused the problem?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to