User "NeilK" changed the status of MediaWiki.r87359. Old Status: new New Status: fixme
User "NeilK" also posted a comment on MediaWiki.r87359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87359#c16526 Commit summary: new subheader messages Comment: 1) The tests for ( mw.UploadWizard.config['something'] !== '' ) are doing the wrong thing. If those items are missing, the value returned is undefined, which is also !== '' You want to use typeof (mw.UploadWizard.config['something']) !== undefined or perhaps mw.isDefined() 2) The URL for bugzilla doesn't work, those saved searches are specific to particular users This will work better, I think. Be careful of those list_id arguments, they refer to ephemeral cached listings. https://bugzilla.wikimedia.org/buglist.cgi?query_format=advanced&component=UploadWizard&resolution=---&product=MediaWiki+extensions 3) could you add target=_blank to all the links, so they don't interrupt an upload? Thanks. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
