User "Fomafix" posted a comment on MediaWiki.r87173.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87173#c16537
Commit summary:

Bug 27047: Nicer design for pre elements in Vector

Comment:

1. (Fixme): <code>pre { word-wrap: break-word; }</code> does not activate text 
wrapping for <code>pre</code> on all browsers. The correct CSS3 definition to 
activate text wrapping for <code>pre</code> is <code>pre { white-space: 
pre-wrap; }</code> [http://www.w3.org/TR/css3-text/#white-space]. To support 
all browsers you should use [https://developer.mozilla.org/en/CSS/white-space]:
<pre>
pre {
      word-wrap: break-word;      /* IE 5.5-7 */
      white-space: -moz-pre-wrap; /* Firefox 1.0-2.0 */
      white-space: pre-wrap;      /* current browsers */
}
</pre>

2. (Fixme): This commit activates text wrapping just on skin Vector. The other 
skins still don't have text wrapping for <code>pre</code>.

3. (Contra): <code>pre</code> is for pre-formatted text to preserve white 
space. It is especially used for source code and ASCII art. Text wrapping is 
bad for source code and ASCII art. If you just want to have a text box with 
border and with text wrapping and without preserving white spaces then don't 
use <code>pre</code>, use <code>div</code> with a special style or a class.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to