User "Catrope" changed the status of MediaWiki.r87379. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r87379. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87379#c16568 Commit summary: Follow up r87310; Adding index to timestamp files in article_feedback and article_feedback_stats_highs_lows tables; Now calculating rating averages in PHP rather than relying on MySQL in populateAFStatistics.php and removed associated cruft Comment: <pre> + 'aa_timestamp >= ' . $this->getLowerBoundTimestamp(), </pre> You need to escape and quote the timestamp too. This can be done with <code>'aa_timestamp >= ' . $db->addQuotes( $this->getLowerBoundTimestamp() )</code> . <pre> + array() // better to do with limits and offsets? </pre> Nah, this is fine. <pre> + 'afshl_avg_ratings' => FormatJson::encode( $data[ 'avg_ratings' ] ), </pre> Don't you want <code>$highs_and_lows['avg_ratings']</code> here? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
