User "Bryan" changed the status of MediaWiki.r80864. Old Status: new New Status: fixme
User "Bryan" also posted a comment on MediaWiki.r80864. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80864#c16604 Commit summary: Followup to r79848 (and really, make it useful...) Turn DatabaseBase::classFromType() into newFromType() factory function for constructing a new object based on a given type and (optional) params. Documented it fairly clearly. I think it looks nicer :) Comment: See bug 28836. Compare: <pre> + return new $class( + isset( $p['host'] ) ? $p['host'] : false, </pre> and <pre> + $this->dbConn = DatabaseBase::newFromType( $this->dbType, + array( + 'server' => $this->dbServer, </pre> <pre> + $this->mDb = DatabaseBase::newFromType( $wgExternalAuthConf['DBtype'], + array( + 'server' => $wgExternalAuthConf['DBserver'], </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
