User "^demon" posted a comment on MediaWiki.r87537.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87537#c16620
Commit summary:

new Categorize extension

Comment:

You should not be using $wgAjaxExportList anymore, that interface is deprecated 
and likely to disappear in the not-so-distant future. The appropriate way 
nowadays is to expose an [[API]] module to do the work you want.

You're also doing a lot of raw SQL which should be replaced with the various 
database methods. You're also using $_POST directly, when you should be using 
WebRequest (stored as a global as $wgRequest)

Couple of style notes for your main entry point: don't use require_once(), use 
the [[Manual:$wgAutoloadClasses|Autoloader]], the LoadAllMessages hook isn't 
necessary at all, and you don't really need to register your hooks in an 
extension function (just do them in the body of the file).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to