User "Bryan" posted a comment on MediaWiki.r87235.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87235#c16635
Commit summary:

Remove the session_write_close() from r72475 since it apparently causes bug 
27891, total breakage of ChronologyProtector. WMF patch only for now, maybe 
Bryan will fix it properly.

Comment:

When using asynchronous upload by url, UploadFromUrlJob stores the result of 
the upload in the session, so that API clients can retrieve the status. This 
session is obviously not the same session as the request session, but that of 
the user who initiated the upload. It therefore calls wfSetupSession() with the 
session id of the uploader.

This would all be unnecessary of course if jobs had a way to communicate their 
results back, but currently there is none.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to