User "Krinkle" changed the status of MediaWiki.r87595. Old Status: new New Status: ok
User "Krinkle" also posted a comment on MediaWiki.r87595. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87595#c16684 Commit summary: Xml::hidden() --> Html::hidden() Xml::hidden() killed Comment: There's a few changes that may not be intended, I've listed them below. Marking FIXME until Reedy confirms they are OK. * '''trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php''' <pre> - $token = array(); </pre> * '''trunk/extensions/CentralAuth/CentralAuthUser.php''' <pre> + * + * @return CentralAuthUser </pre> * '''trunk/extensions/CentralAuth/specials/SpecialGlobalUsers.php''' <pre> - $groups = array_keys( $this->getAllGroups() ); </pre> * '''trunk/extensions/SemanticResultFormats/compat/Html.php''' <pre> * Convenience function to produce an input element with type=hidden, like - * Xml::hidden. + * Xml::hidden. * * @param </pre> (Links like <nowiki>http</nowiki>:<nowiki>//svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php?&pathrev=87595&</nowiki>r<nowiki>1=87594&</nowiki>r<nowiki>2=87595</nowiki> fail due to CodeReview bugs (r1 being linked)) Source: <pre> (Links like <nowiki><nowiki></nowiki>http</nowiki>:<nowiki><nowiki></nowiki>//svn.wikimedia.org/viewvc/mediawiki/ trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php?&pathrev=87595&</nowiki>r<nowiki><nowiki></nowiki>1=87594 &</nowiki>r<nowiki><nowiki></nowiki>2=87595</nowiki> fail due to CodeReview bugs (r1 being linked)) </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
