User "DieBuche" posted a comment on MediaWiki.r83309. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83309#c16693 Commit summary:
Fix bug in makeCollapsible. * The instantHide implementation (added in r82471) didn't cover the case where a table is collapsed by default, it needs to pass the toggle to the function so that the row it is in can be excluded. * The bug was found by user Helder.wiki, also reproducable on the demonstration page (I guess it was cached for everyone, since nobody noticed?) * Demonstration page has been refreshed and all tests are passed now. Comment: There's still one if ( $defaultToggle && $defaultToggle.jquery ) left in L52, 103 & 112. Since you evaluate that a lot, why not check it once and set a flag? Also, a minor typo in L49 (doens't) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
