On Mon, May 9, 2011 at 7:31 PM, Mark A. Hershberger < [email protected]> wrote:
> * http://bugzilla.wikimedia.org/28819: Deleted revision links should > use "rev_id" not "page/timestamp" > * http://bugzilla.wikimedia.org/28820: Diffs using rev_id should work > when one or both revisions are deleted > * http://bugzilla.wikimedia.org/18104: Schema request change so > deleted edits are identified by revisionID > > Brion created thesee bugs which could each be resolved somewhat > independently and suggested them for bugsmash in triage > These are all related to the various issues that got mentioned in comments on bug 21279; I made some core updates on trunk yesterday which make Special:RevisionDelete act a bit more consistently with deleted page revisions that can be identified by a revision ID, thus generating more stable links in the logs: https://bugzilla.wikimedia.org/show_bug.cgi?id=21279#c37 >From there the idea of 'use the darned ar_rev_id value when possible' can be spread out to other places, making things more and more convenient. :) Most of them should be pretty straightforward, or at least self-contained within a particular special page. I do want to double-check on the deployment state though, since 18104 still mentions schema changing: do we have the ar_revid (ar_rev_id) index applied on archive table in production for all wikis, or are there any old ones that still need an index update? Without it these lookups will be hella slow, but based on the current behavior, previous code was already assuming that that was a clean lookup in the few places it was already being done. -- brion _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
