User "Brion VIBBER" changed the status of MediaWiki.r87830.

Old Status: new
New Status: fixme

User "Brion VIBBER" also posted a comment on MediaWiki.r87830.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87830#c16774
Commit summary:

Step 1 of QUnit/TestSwarm support (bug 26908)
* Add jQuery QUnit module
* Add a return value to mw.Map.prototype.set
* Add fallback to 'body' for options.parent in a new $.messageBox

Comment:

Changes to Map.protoype.set in mediawiki.js break a lot of fundamental stuff:

* lots of missing variables like wgScriptPath
* loader's 'debug' state gets load, causing a lot of scripts to get loaded in 
debug mode when loading non-debug
* god knows what else

Recommend immediate revert.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to