User "Krinkle" posted a comment on MediaWiki.r87830.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87830#c16776
Commit summary:

Step 1 of QUnit/TestSwarm support (bug 26908)
* Add jQuery QUnit module
* Add a return value to mw.Map.prototype.set
* Add fallback to 'body' for options.parent in a new $.messageBox

Comment:

Small accident, larger effects.
the first 'return true' within mw.config.set should be outside the 
<code>for</code> loop instead of inside of it, which breaks any group-usage of 
mw.config.set (ie. the mw.config.set with all global variables when the page is 
loaded).

Confirmed locally that this was indeed the cause. I ran some test before 
committing, but this wasn't all that visible. Fixed in my local copy, will 
commit asap.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to