User "Bawolff" posted a comment on MediaWiki.r87942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87942#c16812 Commit summary:
First checkin Comment: I don't really know what this extension actually does/how it works, so this comment might be totally wrong, but: I notice you explicitly use the path $IP/extensions/WebStore for something without checking if the WebStore extension is installed. You should probably do a check to see if its installed, and if it isn't throw an exception or something. (Actually it kind of looks like that's used as a dummy parameter to prevent path disclosure (?) If so probably better to use something that doesn't conflict with an actual extension) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
