User "Platonides" changed the status of MediaWiki.r81536. Old Status: new New Status: fixme
User "Platonides" also posted a comment on MediaWiki.r81536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81536#c16858 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: An array called $success to indicate which items of the batch operations ''failed''? Also, you're storing it whether it's actually good or not. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
