User "Krinkle" changed the status of MediaWiki.r88035.

Old Status: new
New Status: ok

User "Krinkle" also posted a comment on MediaWiki.r88035.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88035#c16860
Commit summary:

* (bug 28945) Keyboard shortcuts on history page no longer work in 1.18

The link replacements for the button were dropping title & accesskey 
attributes, losing the shortcut key. Now copying these and replacing the 
buttons in-place, makes em work.

Comment:

Hm... There are two input[type=submit] on the page (on top and on the bottom), 
looks like PHP only outputs title/accesskey on the bottom one. I guess that 
makes sense since accesskeys need to be unique... Nevermind :) Marking ok, 
works good for the one that do have title/accesskey.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to