User "Catrope" changed the status of MediaWiki.r88053. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r88053. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88053#c16874 Commit summary: Added direct file loading functionality to debug mode for both scripts and styles, with callbacks for module state changes (changing to ready) and executing of jobs and modules awaiting dependency resolutions. These changes also provide a way to used mw.loader.implement with arrays of URLs for the scripts and styles arguments, which will make it possible to implement modules using user scripts. This probably solves bug #27023 - tests to verify that will be coming soon. Comment: <pre> + * @param style Object: Object of CSS strings keyed by media-type or Object of lists of URLs + * keyed by media-type + * as the href attribute when adding a link element to the head </pre> The last line looks out of place. <pre> + if ( !$.isPlainObject( style ) ) { + throw new Error( 'style must be a object or a string, not a ' + typeof style ); + } </pre> "A object" isn't correct English, and strings don't seem to be allowed here. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
