User "Bawolff" posted a comment on MediaWiki.r88129.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88129#c16941
Commit summary:

(bug 28940) When making a thumb of an SVG, and only specifying the height
make the width be the max SVG size, not the natrual width of the SVG.

Some of the linker code here should perhaps be moved. See comments on bug 28940

Comment:

Yeah I know, but $wgSVGMaxSize is the only relevant variable we had. Really all 
it needs is any random big number - the width is checked against the maximum 
later.

As for isVectorized vs canOversize. canOversize might be a better name if we 
were just introducing that now. As it stands, isVectorized is really only used 
to determine if it can be oversized.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to