User "Jack Phoenix" posted a comment on MediaWiki.r88391.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88391#c17013
Commit summary:

Makes sure wgAdditionalMailParams is null in safe mode

The global is used for a call to PHP mail() function as a way to add
additional parameters.  This will cause mail() to send E_NOTICE when
using safe mode.

Since we could use the global at different places, it makes sens to
ensure it has a sane value through Setup.php

Follow up r75557

Comment:

<pre>
+if( !is_null($wgAdditionalMailParams) && wgIniGetBool('safe_mode') ) {
</pre>
Typo, it should be w'''f'''IniGetBool. Also could use a bit of spacing, but 
that's not such a big issue.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to