User "Catrope" posted a comment on MediaWiki.r87497.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87497#c17048
Commit summary:

Per bug 28738 comment 4, pack ResourceLoader URLs by encoding 
foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux

* Expand these URLs in ResourceLoaderContext
* Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in 
mw.loader
* Throw an exception in ResourceLoader::register() for module names that 
contain pipe characters or commas. Commas need to be forbidden for this packing 
feature to work. Pipes were already forbidden but weren't checked for

Comment:

Tagging this and its followup r88076 for 1.17. The feature itself isn't direly 
needed, but the fix for the IE6 403 issue (either the current 
encode-dot-as-exclamation-mark patch or something fixing the actual problem) 
will build on this code and will be much easier to merge if this is merged.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to