User "^demon" posted a comment on MediaWiki.r88467. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88467#c17065 Commit summary:
added wml and rtl language support Comment: <pre> + ExtPatchOutputMobile::$dir = $GLOBALS['wgContLang']->isRTL() ? "rtl" : "ltr"; </pre> Use $wgContLang->getDir(). Also as a general note, we typically declare globals at the beginning of the function, rather than using the $GLOBALS superglobal. Also, I'm not entirely sure why "$GLOBALS['headings'] = $headings;" is necessary in showHideCallbackWML(). The other uses of $headings seem to be static local variables and not this global reference. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
