User "Brion VIBBER" changed the status of MediaWiki.r84491. Old Status: new New Status: reverted
User "Brion VIBBER" also posted a comment on MediaWiki.r84491. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84491#c17126 Commit summary: Fix javascript watch/unwatch with pretty URL mw.util.getParamValue is great but it should not be used to get the 'title' or 'action' parameters: - 'title' is embed in the PATH when using pretty URL - 'action' is hidden when using action paths ($wgActionPaths) Two new functions will give you the expected parameters: - getActionFrom( url ) - getTitleFrom( url ) They firstly attempt to retrieve the action/title from the query string, on failure, they will parse the URL through the action paths. When action paths are not set a default 'view' action is set to wgArticlePath. Should fix one of the r84386 issue: E> mediawiki.action.watch.ajax.js:70 E> Uncaught TypeError: Cannot call method 'replace' of null Comment: This seems to have been since reverted, re-applied in r87964, and re-reverted in r88667. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
