User "Krinkle" posted a comment on MediaWiki.r88699. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88699#c17140 Commit summary:
All kinds of fixes per https://secure.wikimedia.org/wikipedia/mediawiki/wiki/User:Catrope/Extension_review/WikiLove and myself Comment: <pre> 'msg': msg, 'type': $.wikiLove.currentTypeId - + ($.wikiLove.currentSubtypeId != null ? '-' + $.wikiLove.currentSubtypeId : ''), - 'notify': $( '#wlNotifyCheckbox:checked' ).val() + + ($.wikiLove.currentSubtypeId !== null ? '-' + $.wikiLove.currentSubtypeId : ''), }; </pre> This leaves: <pre> $.wikiLove.previewData = { 'header': $( '#wlHeader' ).val(), 'msg': msg, 'type': $.wikiLove.currentTypeId + ($.wikiLove.currentSubtypeId !== null ? '-' + $.wikiLove.currentSubtypeId : ''), }; </pre> Trailing comma's are ignored in WebKit browsers and (like in PHP), but strictly speaking (as seen in IE), this breaks and causes an exception or syntax error. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
