User "Wikinaut" changed the status of MediaWiki.r88726. Old Status: new New Status: ok
User "Wikinaut" also posted a comment on MediaWiki.r88726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88726#c17157 Commit summary: * Moved function show() to be a member of the class instead a global function, this was causing the following error when SpecialOpenIDDashboard::execute is called twice: PHP Fatal error: Cannot redeclare show() (previously declared in extensions/OpenID/SpecialOpenIDDashboard.body.php:42) in extensions/OpenID/SpecialOpenIDDashboard.body.php on line 42 * that function now displays true and null properly * added alias for the special page to not throw notices Comment: r88726 is tested _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
