User "Brion VIBBER" changed the status of MediaWiki.r82307. Old Status: ok New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r82307. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82307#c17181 Commit summary: Add support for namespace prefixed elements in svg. ie. <svg:svg> Fixes bug 27465 Comment: This looks really wrong; it seems to be assuming that namespaces have particular *names*, whereas namespace names are in fact completely arbitrary, and can only be validated by matching the URL specified in the xmlns declaration. On a local copy of https://secure.wikimedia.org/wikipedia/en/wiki/File:US_states_by_total_state_tax_revenue.svg I can confirm that I'm getting errors like this: SvgHandler::getMetadata: Expected <svg> tag, got ns0:svg Although the file looks like it defines the ns0 namespace as SVG just fine: <ns0:svg ... xmlns:ns0="http://www.w3.org/2000/svg"; ... > As a result, although it passes verification for upload, we can't extract metadata so we don't get width/height info and we end up not being able to render it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
