User "Brion VIBBER" changed the status of MediaWiki.r88865.

Old Status: fixme
New Status: resolved

User "Brion VIBBER" also posted a comment on MediaWiki.r88865.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88865#c17187
Commit summary:

Test cases for bug 27465: problems with XML namespace handling break 
SVGMetadataExtractor::getMetadata()


$ php phpunit.php includes/media/SVGMetadataExtractorTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.

..E

Time: 1 second, Memory: 14.00Mb

There was 1 error:

1) SVGMetadataExtractorTest::testGetMetadata with data set #2 
('/var/www/trunk/tests/phpunit/includes/media/US_states_by_total_state_tax_revenue.svg',
 array(593, 959))
MWException: Expected <svg> tag, got ns0:svg

/var/www/trunk/includes/media/SVGMetadataExtractor.php:105
/var/www/trunk/includes/media/SVGMetadataExtractor.php:78
/var/www/trunk/includes/media/SVGMetadataExtractor.php:30
/var/www/trunk/tests/phpunit/includes/media/SVGMetadataExtractorTest.php:14
/var/www/trunk/tests/phpunit/MediaWikiTestCase.php:63
/var/www/trunk/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/var/www/trunk/tests/phpunit/phpunit.php:60

FAILURES!
Tests: 3, Assertions: 2, Errors: 1.

Comment:

r88871 applies the fix for the test case that showed an existing bug.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to