User "Bryan" changed the status of MediaWiki.r72475. Old Status: fixme New Status: new
User "Bryan" also posted a comment on MediaWiki.r72475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72475#c17212 Commit summary: Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to be done for the normal UI. PHPUnit tests are updated and should cover most code paths that can be called from the API. ApiUpload: * Added "statuskey" parameter; this is the key that is returned by an async upload * Refactored warnings transformation into its own function * filename is no longer required on all uploads UploadFromUrlJob: * Moved upload results to its own entry in $_SESSION, instead of using the one from upload * Fix storing in session by calling wfSetupSession and session_write_close where needed Tests: * Set $wgUser in ApiSetup, so that individual tests don't have to do this for themselves * Added tests to cover most code paths from the API * Fixed UploadFromUrlTestSuite so that its tests are included in a regular phpunit invocation (something strange with the AutoLoader; not sure what) Other files: * Allow passing session id to wfSetupSession * Explicitly close the session before doing jobs, so that jobs can't manipulate the current session Comment: Fixed in r88904. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
