User "Catrope" posted a comment on MediaWiki.r88883. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88883#c17218 Commit summary:
(bug 28840) URLs with dots break because of IE6 security check * Replace the overly paranoid regex with a function that simulates IE6's behavior * Remove the UA check in isPathInfoBad(), was causing more problems than it was worth * Revert r87711, going back to using dots for dots in ResourceLoader URLs, instead of exclamation marks * Append &* to ResourceLoader URLs. * is an illegal character in extensions, and putting it at the end of the URL ensures that both IE6 and our detection function will deem the URL to have no extension (unless something like .html? appears in the query string, but in that case we're screwed no matter what) Comment: No, a question mark can't end up in the middle of an RL query string, except if a question mark appears in a module name. But we could (and probably should) just disallow that. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
