User "Krinkle" posted a comment on MediaWiki.r88794. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88794#c17271 Commit summary:
Use $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order. This means mw.util.jpegmeta doesn't depend on mw.util loading first any more Comment: The ResourceLoader module [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/Resources.php?annotate=80775#l357 never had] a dependancy on the <code>mediawiki.util</code> so module, it assumed it was loaded, so that's fixed in this commit. But on the other hand, this: * might brake mediawiki.util.js if loaded asynchronously (could override it if not defined yet but started execution of that file, or is that not possible and am I paranoid here?) * jpegmeta perhaps shouldn't extend mediawiki.util at all. ** or, we define mw.util in mediawiki.js as an empty object (no need for extending that way) ** or, we define mw.libs in mediawiki.js as an empty object (no need for extending that way) *** in that case mw.util's definition can co back to an object literal. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
