User "Krinkle" changed the status of MediaWiki.r88706. Old Status: new New Status: ok
User "Krinkle" also posted a comment on MediaWiki.r88706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88706#c17273 Commit summary: * (bug 29107) Fix regression in ResourceLoader debug mode for WikiEditor One of WikiEditor's modules had only messages, no scripts; updates to the debug mode loader had ended up failing in the case where no scripts got passed in (if passed with a loader function we were fine, hence non-debug mode being ok) This commit explicitly checks for the empty-array case and marks the module as ready immediately, instead of waiting for the last item in the loop to finish, which never happens. :) Also consolidated three calls to the same few lines of code into a lambda function. Comment: I'm not sure how this failed before this commit, I know it works now. Could you perhaps add a test suite for this in <code>/tests/qunit/suites/</code> ? Probably something with <code>mw.loader.implement</code> and <code>mw.messages.exists</code>. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
