User "Krinkle" posted a comment on MediaWiki.r84475.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c17276
Commit summary:
Blame hashar for this giant commit; he teased me for making so many smaller
ones earlier... :D
* Internalise $mAddress/$mUser, $mBy/$mByName, $mEnableAutoblock, $mId as
getTarget(), getBlockers(), isAutoblocking(), getId().
* This required editing AbuseFilter and CheckUser backwards-incompatibly, so
push the rest of the changes out to those extensions.
* Attack the evil 14-parameter constructor and gratuitously-confusing
newFromDB( $notVeryImportantParameter, $moreImportantParameter)
* Reimplement the hack for bug 13611 in a slightly less fragile fashion; could
still do with further cleanup, but then again the login frontend is its own can
of worms... :S
* Remove transitionary getTargetAndType() and newFromTargetAndType() methods
* Some optimisation in parseTarget()
* Fix the broken phpunit test mentioned in r84251
Comment:
Presumably this line (since it's the only core code-changing line in that
revision):
<pre>
- } elseif( $target === null && $vagueTarget === null ){
+ } elseif( $target === null && $vagueTarget == '' ){
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
