User "Krinkle" changed the status of MediaWiki.r86942. Old Status: new New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r86942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86942#c17279 Commit summary: Followup to r86603 per Bug 28681 : Create public array mw.toolbar.buttons. User scripts can modify it, until it's written to the DOM on doc.ready Comment: <pre> + if ( buttons[i] instanceof Array ) { </pre> This doesn't work cross-browser, use <code>$.isArray</code> instead. The rest looks OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
