User "Platonides" changed the status of MediaWiki.r89206. Old Status: ok New Status: fixme
User "Platonides" also posted a comment on MediaWiki.r89206. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89206#c17352 Commit summary: * Made the profiler work in HipHop: ** Don't try to set a global variable in the same file as a class definition (Profiler.php). Set it in WebStart.php instead. ** In StartProfiler.sample, don't use require_once() to get ProfilerStub. * Removed the setproctitle() stuff from ProfilerStub, the extension is not maintained and doesn't work with Apache 2.x * Added an optimisation to wfProfileIn() and wfProfileOut() to reduce the overhead when profiling is not enabled * Added the ability to configure in StartProfiler.php whether CPU time or wall-clock time is used, avoiding recompilation Comment: PHP Warning: Missing argument 1 for Profiler::__construct(), called in phase3/includes/profiler/Profiler.php on line 72 and defined in trunk/phase3/includes/profiler/Profiler.php on line 45 Maybe it should be function __construct( $params = array() ) ? What about delaying profiler initialization a few lines and setting $wgProfiler['class'] = 'Profiler'; in LocalSettings instead? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
