User "Brion VIBBER" posted a comment on MediaWiki.r87584. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87584#c17375 Commit summary:
More versions added to @deprecated tags Couple of inbound calls fixed up Some ancient code removed as it's been marked deprecated Comment: Thanks, just remember to test refactorings before committing. :) It can also help to break up large commits like this; a commit that was labeled "replaced remaining deprecated Linker::tooltipAndAccessKey() calls with Linker::tooltipAndAccessKeyAttribs()" would probably have been easier to identify as slipping in a little bug, as somebody might have noticed the mismatched function signatures. This commit ended up kinda big and I suspect reviewers didn't pay as much attention after clicking through to show a few diffs that were mostly adjustments to comments or removal of unused functions. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
