User "Platonides" posted a comment on MediaWiki.r89230. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89230#c17380 Commit summary:
The big regex at doMagicLinks deserves being more thoroughly studied. Comment: I didn't benchmark it. I was dealing with [[bugzilla:29197]] and realised how big it is and that it didn't had /S. /S is equivalent to doing a pcre_verify, which is currently only useful when the regex can begin with different characters (as this is the case), so it should provide some benefits. And the cost of this extra study should be zero as the resulting regex should be cached by apc (but even without that it is probably worth). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
