User "Brion VIBBER" posted a comment on MediaWiki.r88706.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88706#c17397
Commit summary:

* (bug 29107) Fix regression in ResourceLoader debug mode for WikiEditor

One of WikiEditor's modules had only messages, no scripts; updates to the debug 
mode loader had ended up failing in the case where no scripts got passed in (if 
passed with a loader function we were fine, hence non-debug mode being ok)
This commit explicitly checks for the empty-array case and marks the module as 
ready immediately, instead of waiting for the last item in the loop to finish, 
which never happens. :)

Also consolidated three calls to the same few lines of code into a lambda 
function.

Comment:

Think I can whip something together for this...

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to