User "Krinkle" posted a comment on MediaWiki.r89243. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89243#c17404 Commit summary:
Follow-up to r88706: add qunit regression test case for bug 29107. Confirms that messages-only modules trigger a ready callback. Comment: there's <code>start()</code> but no <code>stop()</code> on top or <code>start()</code> in the success-callback. Per IRC discussion, async sucks in combination with <code>expect()</code> if there's a chance the error callback wont get called either. But without the async stop/start the test result could end up in another block and the QUnit would nag "Expected 1 assertions, but 0 were run". Hm... just looking at the QUnit source, a possible work-around would be to use the [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.qunit.js?revision=87848&view=markup#l414 timeout] feature of <code>stop()</code> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
