User "Krinkle" posted a comment on MediaWiki.r45497.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45497#c17415
Commit summary:
* Made it possible to set $wgLogo to false and have no logo. Made this the
default, installer-configurable.
* Introduced $wgDeletedDirectory to replace obsolete $wgFileStore and
installer-configurable
* Turned the "environment" page into a "welcome" page. Still needs some work to
make it more welcoming.
* Refactored the getLabelled*() from InstallerDBType.php into WebInstaller
where it can be useful for the WebInstaller pages
* Implemented pages "Name" and "Options". Finished the MySQL settings form.
* Implemented documentation pages which render files like README as wikitext.
* Removed MediaWiki copyright/license from navigation regions and put them on
the welcome page.
* Split the bulk CSS and JS off to separate files
Comment:
Looks like this commit introduced the following "feature":
<pre>
/**
+ * User rights profiles
+ */
+ var $rightsProfiles = array(
+ 'wiki' => array(),
+ 'no-anon' => array(
+ '*' => array( 'edit' => false )
+ ),
+ 'fishbowl' => array(
+ '*' => array(
+ 'createaccount' => false,
+ 'edit' => false,
+ ),
+ ),
+ 'private' => array(
+ '*' => array(
+ 'createaccount' => false,
+ 'edit' => false,
+ 'read' => false,
+ ),
+ ),
+ );
</pre>
However, in the current 1.19 svn HEAD this is not working (maybe it never did),
these values are ignored and not put into the LocalSettings.php write/download.
This variable and it's storage in _RightsProfile has been moved about half a
dozen times this 2009, currently it's used in three places
* _RightsProfile:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/installer/Installer.php?revision=89037&view=markup#l175
* form:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/installer/WebInstallerPage.php?revision=89037&view=markup#l781
* submit:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/installer/WebInstallerPage.php?revision=89037&view=markup#l1012
I guess the part that's missing is some kind of loop that sets values
overriding parts of {{wg|GroupPermissions}}.
I'm asking here to verify that it was introduced here, and that it never worked.
Or does it ?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
