User "Reedy" changed the status of MediaWiki.r85288. Old Status: new New Status: fixme
User "Reedy" also posted a comment on MediaWiki.r85288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85288#c17429 Commit summary: Implement magic accessors for RequestContext variables: you can now just call $context->request->stuff(), and that is internally mapped to the get accessor. Rename the private variables to the old $mName syntax: I know that that's "discouraged in new code", but in this case it stops over-clever IDEs highlighting the magic accesses as potential visibility errors and sticking big error tags on them. Comment: Got a big of a whinge here... <source lang="php"> class RequestContext { /** * @var WebRequest */ private $mRequest; </source> <source lang="php"> class MediaWiki { /** * TODO: fold $output, etc, into this * @var RequestContext */ private $context; public function request( WebRequest $x = null ){ return wfSetVar( $this->context->request, $x ); } public function output( OutputPage $x = null ){ return wfSetVar( $this->context->output, $x ); } </source> We've got the usage of $output and $mOutput inside and outside of the context, and it looks messy Same for $request and $mRequest _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
