On Wed, Jun 1, 2011 at 12:43 PM, Aryeh Gregor <[email protected] > wrote: [snip]
> The point is, people's code should only be rejected with some specific > reason that either a) lets them fix it and resubmit, or b) tells them > definitively that it's not wanted and they shouldn't waste further > effort or hope on the project. [snip] "This isn't ready for core yet -- code looks a bit dense and we don't understand some of what it's doing yet. Can you help explain why you coded it this way and add some test cases?" It's usually better if you can do this at a pre-commit stage: when reviewing a patch on bugzilla, when looking over a merge request from a branch, etc. But it's ok to pull something back out of trunk to be reworked, too. -- brion _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
