User "Fomafix" posted a comment on MediaWiki.r88502.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88502#c17444
Commit summary:

Trial commit to fix bug #29043: “The 'Contents box' in the "Printable version" 
rendering is stupid”

Other people should try my patch and see if they agree that printing the
contents box on paper is stupid.  Just commenting on the bug with your
opinion would be helpful.

Comment:

This gadget already exists. See bug 482. But this feature doesn't work anymore 
since porting to ResourceLoader in r78941. In r78941 the JavaScript part to add 
and remove the css class <code>tochidden</code> is lost. <code>tochidden</code> 
is still in 
[http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/commonPrint.css?view=annotate#l120
 commonPrint.css]. 
[https://bugzilla.wikimedia.org/attachment.cgi?id=8607&action=diff Here] is a 
patch as a follow-up to r78941 to reactivate <code>tochidden</code>. Please 
revert r88502 and integrate the patch.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to