User "Platonides" changed the status of MediaWiki.r88588. Old Status: new New Status: fixme
User "Platonides" also posted a comment on MediaWiki.r88588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88588#c17460 Commit summary: $wgArticle is deprecated! Possible removal in 1.20 or 1.21! * Encapsulate index.php in wfIndexMain() (similar to r77873) * Kill $wgArticle check in Exception, not necessary anymore * Kill $wgArticle in Setup, also not necessary * Add angry note about $wgArticle to rebuildFileCache. * Remove note about $wgArticle in Parser since it's dying anyway Comment: The $wgArticle code does nothing (other than being discoverable when grepping the codebase). Anything which relied on $wgArticle will already have run by that time. You should have done $wgArticle = &$article; before the $mediaWiki->performRequestForTitle() call (will be harder now after r88898 refactorization). <pre> + /** + * $wgArticle is deprecated, do not use it. This will possibly be removed + * entirely in 1.20 or 1.21 + * @deprecated since 1.19 + */ + global $wgArticle; + $wgArticle = $article; </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
