User "MaxSem" posted a comment on MediaWiki.r89351. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89351#c17467 Commit summary:
- Changed the AJAX interaction: now the AJAX request returns an object with all info to build the dialog, instead of the dialog code. - added the jquery.validate plugin (from http://bassistance.de/jquery-plugins/jquery-plugin-validation/) - added jquery.formBuilder, written on top of jquery.validate, to manage dialog building and client-side validation - added server-side validation of preference descriptions - implemented the "assume-default" policy for gadget options which fail validation Comment: <pre>if ( strcmp( $fieldName, 'type' ) == 0)</pre> Hey, you're not writing in C, just use comparison operator :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
