User "Helder.wiki" posted a comment on MediaWiki.r89198.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89198#c17473
Commit summary:

Suppress AFT from all print outputs. I am adding a @media rule, but also
suppressing rendering of the widget in the &printable version (which does
not respect the @media setting when rendered to the screen). I tried just
using the noprint class, but it does not appear to be present in the older
skins.

Comment:

I noticed a small inconsistency:
* 
[https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Salt_Creek_(White_River)&printable=
 Salt Creek (White River)&printable=] (non printable, rateable)
* 
[https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Salt_Creek_(White_River)&printable=0
 Salt Creek (White River)&printable=0] (non printable, rateable)
* 
[https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Salt_Creek_(White_River)&printable=yes
 Salt Creek (White River)&printable=yes] (printable, non rateable)
* 
[https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Salt_Creek_(White_River)&printable=LoremIpsum
 Salt Creek (White River)&printable=LoremIpsum] (printable, but '''rateable''')
I'm not sure how MediaWiki interprets the "printable" parameter but, 
empirically, from the examples above I suppose it is not checking for the exact 
value "yes", since any non-empty/non-zero value seems to make the page 
"printable".

Does anyone knows exactly how this parameter should be interpreted?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to