User "Krinkle" changed the status of MediaWiki.r87360. Old Status: new New Status: deferred
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87360#c0 Commit summary: mw.util.test fixes * Remove hiding of rows after the test, in almost all cases someone will want to unhide these, especially in case of an error; Plus, there were some inconsistencies in firefox with the hovering of the last (non-collapsible) row. * Changing mw.util.addCSS to a style that is actually visible on the action=mwutiltest page. * Making the entire row red in case of errors (easier finding of the error) * Moving $.isDomElement tests to mw.util.test instead of in comments * Adding missing tests for all mw.util properties * Fix bug where $.isDomElement fails if the passed argument isn't an object at all (eg. null or undefined). Check variable first before checking object property (<code>$.isDomElement( document.getElementById('notexist') );</code> returned TypeError: Result of expression 'el' [null] is not an object.) ** Adding test for this * Try/Catch the evaluation ** Reports catched exceptions through mw.log instead of using throw. This way non-consoled browsers can be easily debugged through mw.log's console. ** Fixes: (bug 28803) mw.util.test doesn't handle exceptions * Using a canonical variable instead of a localized one in the tests. ** Fixes: (bug 28788) 2 tests related to wgTitle in mediawiki.util.test are broken for non-English wikis. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
