User "Krinkle" changed the status of MediaWiki.r86060. Old Status: new New Status: ok
User "Krinkle" also posted a comment on MediaWiki.r86060. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86060#c17513 Commit summary: Changing icons used in installer to GNOME ones, like the rest of vector skin. Also fixing Bug 28298 (one border extens a few pixel too much in installer) Comment: <pre> --- trunk/phase3/skins/common/config.css (revision 86059) +++ trunk/phase3/skins/common/config.css (revision 86060) @@ -68,7 +68,7 @@ .config-error-box { border: 2px solid #f00; - margin: 0.4em; + margin: 0.5em; clear: left; } </pre> Please commit independant changes in seperate commits. A bit more information on it would be helpful as well. The [https://bugzilla.wikimedia.org/attachment.cgi?id=8341&action=edit screenshot] from bug 28298 shows the right edge peeking out behind the sidebar about 0.1em. A little investigation: The sidebar has a margin of 0.5em, the infoboxes (<code>.config-warning-box</code>, <code>.config-error-box</code>, etc.) had a margin of 0.4em. So in cases both an infobox and sidebar are in the same Installer view, it peeked out. This commit fixed it for <code>.config-error-box</code> but not for <code>.config-warning-box</code>. Also as of r88109 a central <code>.mw-infobox</code> class has been made for these. Perhaps we should fix the margin on the general class instead of this specific class for errors (and then remove the margin declaration all together from the 'error' and 'warning' uses since they all have mw-infobox as well now). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
