User "Brion VIBBER" changed the status of MediaWiki.r89409. Old Status: fixme New Status: reverted
User "Brion VIBBER" also posted a comment on MediaWiki.r89409. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89409#c17548 Commit summary: * suggestion for using tables.sql parsing instead of database query for tables list needed for phpunit * would be better option IMO since the database is not necesserally dedicated to MW install Comment: Reverted in r89429; this implementation isn't compatible with DatabaseMySQL's implementation. Several differences: * listTables is expected to return tables that actually exist in the database -- this returns a fixed set of tables that MediaWiki core knows about * listTables is expected to return actual raw table names, including whatever prefix -- this wouldn't include a prefix * listTables $prefix parameter can be used to restrict which tables are pulled from the list, but this isn't respected here _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
