User "Brion VIBBER" posted a comment on MediaWiki.r89278. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89278#c17562 Commit summary:
Fix Bug #29231: PhpHttpRequest doesn't support HTTPS Tested fix with PHPUnit Tests that aren't currently executed by CruiseControl b/c they're marked “broken” till someone comes up with some reasonable unit tests that will work for everyone. Comment: Adding protocols increases the security attack surface and doesn't have an obvious practical benefit. Already, lots of stuff calling Http or MwHttpRequest assumes, well, HTTP or HTTPS and they assume semantics based on that like: * the notion of redirects * meaning and validity of return codes _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
