User "Brion VIBBER" changed the status of MediaWiki.r89273. Old Status: new New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r89273. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89273#c17566 Commit summary: Add some documentation Swap if ( $foo ) { $this->addFields( 'foo' ); } for $this->addFieldsIf( 'foo', $foo ); etc Also swap $this->addFieldsIf( 'foo', $foo ); $this->addFieldsIf( 'foo2', $foo ); for $this->addFieldsIf( array( 'foo', 'foo2' ), $foo ); Micro-optimisation and readability! Comment: Looks ok and doesn't seem to cause any new phpunit failures in API tests. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
