User "Brion VIBBER" changed the status of MediaWiki.r89407. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r89407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89407#c17573 Commit summary: Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null Comment: If refactoring, can you go ahead and add some unit test cases? This always helps to build confidence that the modified code works correctly (though it looks ok offhand). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
