User "Tim Starling" posted a comment on MediaWiki.r85288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85288#c17576 Commit summary:
Implement magic accessors for RequestContext variables: you can now just call $context->request->stuff(), and that is internally mapped to the get accessor. Rename the private variables to the old $mName syntax: I know that that's "discouraged in new code", but in this case it stops over-clever IDEs highlighting the magic accesses as potential visibility errors and sticking big error tags on them. Comment: The get functions in this revision call half the codebase: User, Language, Title, etc. You can't guarantee that nobody is ever going to use RequestContext from one of those modules. If you tried to use it in places where it was safe, that would establish a convention which would then be applied to places where it is not safe. It's better to just remove the temptation. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
